Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Docker Tag Logic #840

Merged
merged 2 commits into from
Nov 28, 2024
Merged

Update Docker Tag Logic #840

merged 2 commits into from
Nov 28, 2024

Conversation

alexnorell
Copy link
Contributor

@alexnorell alexnorell commented Nov 27, 2024

Description

Update the release logic to support the following cases:

  • releases will also push to latest if the GitHub release is tagged as the latest release AND the version in version.py matches the tag of the release. The tag of the release is normalized to remove the leading v. If both of those aren't true, the container tag will be set to the tag of the github release.
  • push to main will only tag an image as main. This will allow for a bleeding-edge build
  • custom tag will prepend the version from version.py to the tag, and will ONLY allow pushing the custom tag
  • Force push will only update the container tag that matches the value in version.py

docker_tag_flow

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How has this change been tested, please provide a testcase or example of how you tested the change?

This has been tested on a separate repository to verify all this functionality works:

Any specific deployment considerations

Release will push to latest again. This will also allow us to enable main builds in the future if desired.

Docs

  • Docs updated? What were the changes:

@PawelPeczek-Roboflow PawelPeczek-Roboflow merged commit 8cb07a7 into main Nov 28, 2024
71 checks passed
@PawelPeczek-Roboflow PawelPeczek-Roboflow deleted the fix/latest_release branch November 28, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants