Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Setup article #123

Merged
merged 10 commits into from
Mar 19, 2024
Merged

Update Setup article #123

merged 10 commits into from
Mar 19, 2024

Conversation

LouieK22
Copy link
Contributor

@LouieK22 LouieK22 commented Feb 20, 2024

Updates setup article to modern practices

docs/setup-guide.mdx Outdated Show resolved Hide resolved
docs/setup-guide.mdx Show resolved Hide resolved
docs/setup-guide.mdx Outdated Show resolved Hide resolved
docs/usage.mdx Outdated Show resolved Hide resolved
@LouieK22 LouieK22 requested a review from Dionysusnu February 21, 2024 20:45
@LouieK22
Copy link
Contributor Author

Split Usage changes to #124, I'll get a PR up for that.

Otherwise, made the requested changes, you're good to review again @Dionysusnu

docs/setup-guide.mdx Outdated Show resolved Hide resolved
docs/setup-guide.mdx Outdated Show resolved Hide resolved
@LouieK22 LouieK22 requested a review from Dionysusnu February 22, 2024 20:51
Copy link
Contributor

@Dionysusnu Dionysusnu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from the one comment

docusaurus.config.ts Outdated Show resolved Hide resolved
@LouieK22
Copy link
Contributor Author

LouieK22 commented Mar 4, 2024

Should this PR also close #77 or do we want separate docs for that?

@osyrisrblx osyrisrblx merged commit 9b8d2ef into roblox-ts:master Mar 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants