Improved error handling for child processes

src/commands/init.ts

@@ -1,4 +1,4 @@
-import { exec, ExecException } from "child_process";
+import { spawn } from "child_process";
 import fs from "fs-extra";
 import kleur from "kleur";
 import { lookpath } from "lookpath";
@@ -64,14 +64,17 @@ const packageManagerCommands: {
 
 function cmd(cmdStr: string, cwd: string) {
 	return new Promise<string>((resolve, reject) => {
-		exec(cmdStr, { cwd }, (error, stdout) => {
-			if (error) {
-				reject(error);
-			}
-			resolve(stdout);
-		});
-	}).catch((error: ExecException) => {
-		throw new InitError(`Command "${error.cmd}" exited with code ${error.code}\n\n${error.message}`);
+		const [command, ...args] = cmdStr.split(" ");
+		const childProcess = spawn(command, args, { cwd });
+		let output = "";
+		childProcess.stdout.on("data", data => (output += data));
+		childProcess.stderr.on("data", data => (output += data));
+		childProcess.on("close", code =>
+			code === 0
+				? resolve(output)
+				: reject(new InitError(`Command "${cmdStr}" exited with code ${code}\n\n${output}`)),
+		);
+		childProcess.on("error", reject);
 	});
 }
 

src/index.ts

@@ -35,6 +35,7 @@ yargs
 	})
 	.parseAsync()
 	.catch(e => {
+		process.exitCode = 1;
 		if (e instanceof LoggableError) {
 			e.log();
 		} else {