-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bun support. #15
base: master
Are you sure you want to change the base?
Add bun support. #15
Conversation
New iteration of roblox-ts/roblox-ts#2485 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a blazingly fast JS runtime
Note that this won't allow you to use Bun's runtime itself, just the package manager. You'd need to change the compiler itself to support the runtime. We've tried in the past, and it turned out to be quite a lot of work.
@Dionysusnu status? |
? |
Apologies for missing your first message, but I'm not the maintainer of roblox-ts, just a contributor. |
@osyrisrblx do you mind looking at this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've looked into it some more, and I think it's a better option to stick with npm init -y
for the init command. As explained in the earlier comment, bun can only work as a package manager for roblox-ts, the runtime isn't compatible. Therefore, I think it's better to init with npm
, which just creates the package.json
. The things bun init
does on top of that are either incorrect for roblox-ts, or already covered by other parts of the init process.
I've left suggestions on how to add this in the code.
We cannot depend on NPM, some users don't even have NPM installed. |
My previous comment (in the suggestion thread) applies:
|
I think the condition check is enough. |
What do you mean by condition check? |
This PR Adds support for Bun, a blazingly fast JS runtime, package manager and much more.
closes #13