Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Sortino ratio for portfolio #459

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dpapakyriak
Copy link
Contributor

I implemented an initial attempt for the sorting ratio, as asked in issue #401. In order to achieve this, I initially implemented a function to calculate the downside deviation for all assets. Then, I made the sorting_ratio() function to return the sorting ratio for a given portfolio. This is a draft, please review and contact me via email to fix any issues and/or any additional documentation.

@robertmartin8
Copy link
Owner

I'm not merging this for now for a couple of reasons:

  1. I think there are probably much more efficient vectorised ways of computing downside deviation, something along the lines of a[a<thresh].std().
  2. Variable name conventions: PyPortfolioOpt uses snake_case as per PEP8

@chriss1245
Copy link

Is there any update related to this topic?
I consider this feature may be very interesting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants