Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(composer): Actualize composer.json dependencies #542

Merged
merged 1 commit into from
Feb 12, 2021
Merged

feat(composer): Actualize composer.json dependencies #542

merged 1 commit into from
Feb 12, 2021

Conversation

SerafimArts
Copy link
Contributor

@SerafimArts SerafimArts commented Feb 11, 2021

Please Note: This PR is blocked by the presence of a spiral/roadrunner-cli package on the pakagist and can only be accepted after it appears in the packagist's repository.

See https://github.com/spiral/roadrunner-cli/issues/1

Reason for This PR

The metapackage serves to provide a convenient way to install a set of dependencies. In this case, package spiral/roadrunner replaces the installation of three dependencies:

  • spiral/roadrunner-worker
  • spiral/roadrunner-cli
  • spiral/roadrunner-http

Description of Changes

  • Added support for roadrunner cli tool (installer) package.
  • Added spiral/roadrunner-http dependency.
    • Note: If the user does not need it, then he can use the installation of the roadrunner-worker separately.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT license.

PR Checklist

[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]

  • All commits in this PR are signed (git commit -s).
  • The reason for this PR is clearly provided (issue no. or explanation).
  • The description of changes is clear and encompassing.
    - [ ] Any required documentation changes (code and docs) are included in this PR.
    - [ ] Any user-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.

@rustatian rustatian changed the title Actualize composer.json dependencies feat(composer): Actualize composer.json dependencies Feb 12, 2021
@rustatian rustatian self-assigned this Feb 12, 2021
@rustatian rustatian added the A-other Area: other label Feb 12, 2021
@rustatian rustatian added this to the 2.0.0 milestone Feb 12, 2021
@rustatian
Copy link
Member

@wolfy-j I guess that roadrunner-cli is already in the packagist. If true, feel free to merge this PR 👍

@rustatian rustatian self-requested a review February 12, 2021 08:48
Copy link
Member

@rustatian rustatian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rustatian rustatian merged commit f8dd689 into roadrunner-server:master Feb 12, 2021
@rustatian rustatian linked an issue Feb 16, 2021 that may be closed by this pull request
33 tasks
@rustatian rustatian removed a link to an issue Feb 16, 2021
33 tasks
@rustatian
Copy link
Member

linked #368

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-other Area: other
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants