Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stabilization(RC): rc stabilization #530

Merged
merged 17 commits into from
Feb 11, 2021
Merged

stabilization(RC): rc stabilization #530

merged 17 commits into from
Feb 11, 2021

Conversation

rustatian
Copy link
Member

@rustatian rustatian commented Feb 4, 2021

Reason for This PR

Code stabilization before RC

Description of Changes

  1. Move the RR worker state to the worker package.
  2. Add extra guard to the workers_watcher Get operation to ensure, that the requested worker in the Ready state.
  3. Test_Static_Pool_Handle_Dead behaves differently now. Previously it was an error when all workers in the ErrorState and user tried to Exec payload. Now, the worker watcher checks for the worker state before push it to the consumer. And if a worker not in the StateReady state, the worker watcher removes such worker from the stack and allocates a new one.
  4. Fast []byte to string conversion (>100x times)
  5. Fix issue with disabled endure interface dependencies. Ref: bug(init): Handle disabled interface dependencies endure#85
  6. Add container for the workers -> pkg/worker_watcher/container

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT license.

PR Checklist

[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]

  • All commits in this PR are signed (git commit -s).
  • The reason for this PR is clearly provided (issue no. or explanation).
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this PR.
  • Any user-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.

@rustatian rustatian added the A-other Area: other label Feb 4, 2021
@rustatian rustatian added this to the 2.0.0 milestone Feb 4, 2021
@rustatian rustatian self-assigned this Feb 4, 2021
@codecov
Copy link

codecov bot commented Feb 4, 2021

Codecov Report

Merging #530 (509abc7) into master (7978c59) will decrease coverage by 1.05%.
The diff coverage is 76.49%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #530      +/-   ##
==========================================
- Coverage   68.93%   67.88%   -1.06%     
==========================================
  Files          64       65       +1     
  Lines        3206     3263      +57     
==========================================
+ Hits         2210     2215       +5     
- Misses        705      763      +58     
+ Partials      291      285       -6     
Impacted Files Coverage Δ
internal/protocol.go 50.00% <ø> (ø)
pkg/worker_watcher/container/stack.go 0.00% <0.00%> (ø)
plugins/http/config/http.go 53.22% <0.00%> (ø)
pkg/pool/supervisor_pool.go 67.85% <50.00%> (+2.38%) ⬆️
plugins/kv/memcached/plugin.go 70.87% <50.00%> (+3.50%) ⬆️
pkg/worker/state.go 79.31% <79.31%> (ø)
pkg/worker/sync_worker.go 77.08% <87.50%> (-1.77%) ⬇️
pkg/pool/static_pool.go 80.14% <89.28%> (+0.57%) ⬆️
pkg/worker_watcher/worker_watcher.go 85.45% <89.33%> (+7.53%) ⬆️
pkg/worker/worker.go 90.66% <91.66%> (+2.66%) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7978c59...509abc7. Read the comment docs.

@rustatian rustatian requested a review from wolfy-j February 11, 2021 10:58
@rustatian rustatian changed the title [WIP] stabilization(RC): rc stabilization stabilization(RC): rc stabilization Feb 11, 2021
@rustatian rustatian marked this pull request as ready for review February 11, 2021 10:58
@rustatian rustatian merged commit 8f6cafd into master Feb 11, 2021
@bors bors bot deleted the release_stabilization branch February 11, 2021 11:06
@rustatian
Copy link
Member Author

linked #368

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-other Area: other
Projects
None yet
2 participants