-
-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stabilization(RC): rc stabilization #530
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #530 +/- ##
==========================================
- Coverage 68.93% 67.88% -1.06%
==========================================
Files 64 65 +1
Lines 3206 3263 +57
==========================================
+ Hits 2210 2215 +5
- Misses 705 763 +58
+ Partials 291 285 -6
Continue to review full report at Codecov.
|
Endure updated to beta.23 Tests update
Add fast and slow paths
Update tests
# Conflicts: # go.sum
rustatian
changed the title
[WIP] stabilization(RC): rc stabilization
stabilization(RC): rc stabilization
Feb 11, 2021
wolfy-j
approved these changes
Feb 11, 2021
This was
linked to
issues
Feb 11, 2021
33 tasks
linked #368 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for This PR
Code stabilization before RC
Description of Changes
Get
operation to ensure, that the requested worker in theReady
state.Test_Static_Pool_Handle_Dead
behaves differently now. Previously it was anerror
when all workers in theErrorState
and user tried toExec
payload. Now, the worker watcher checks for the worker state before push it to the consumer. And if a worker not in theStateReady
state, the worker watcher removes such worker from the stack and allocates a new one.[]byte
tostring
conversion (>100x times)pkg/worker_watcher/container
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT license.
PR Checklist
[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]
git commit -s
).CHANGELOG.md
.