refactor: Use friendsofphp/php-cs-fixer instead of squizlabs/php_code…

…sniffer (#22)

.github/workflows/run-test.yml

@@ -35,7 +35,5 @@ jobs:
                       ${{ runner.os }}-php-${{ matrix.php-version }}-
             - name: Install Dependencies
               run: composer install --no-scripts --no-ansi --no-interaction --no-progress
-            - name: Run PHP Code Sniffer
-              run: vendor/bin/phpcs --extensions=php --warning-severity=0 --standard=PSR12 -p ./src
             - name: Run PHPStan
               run: vendor/bin/phpstan analyse --no-progress -c phpstan.neon

composer.json

@@ -17,8 +17,7 @@
         "ext-openssl": "*"
     },
     "require-dev": {
-        "phpstan/phpstan": "^1.5.3",
-        "squizlabs/php_codesniffer": "^3.5"
+        "phpstan/phpstan": "^1.5.3"
     },
     "autoload": {
         "psr-4": {

src/PasswordGenerator.php

@@ -14,7 +14,6 @@ class PasswordGenerator extends RandomGenerator implements PasswordGeneratorInte
      * The available characters in each set are user friendly - there are no ambiguous
      * characters such as i, l, 1, o, 0, etc.
      *
-     * @param int $length
      * @return string
      *
      * @see https://gist.github.com/tylerhall/521810
@@ -35,7 +34,7 @@ public function generatePassword(int $length = 12)
         }
 
         $all = \mb_str_split($all);
-        for ($i = 0; $i < $length - count($sets); $i++) {
+        for ($i = 0; $i < $length - count($sets); ++$i) {
             $password .= $all[array_rand($all)];
         }
 

src/PasswordGeneratorInterface.php

@@ -7,7 +7,6 @@
 interface PasswordGeneratorInterface
 {
     /**
-     * @param int $length
      * @return string
      */
     public function generatePassword(int $length = 12);

src/RandomGenerator.php

@@ -11,10 +11,7 @@ class RandomGenerator
     protected ?LoggerInterface $logger;
     protected bool $useOpenSsl;
 
-    /**
-     * @param LoggerInterface|null $logger
-     */
-    public function __construct(LoggerInterface $logger = null)
+    public function __construct(?LoggerInterface $logger = null)
     {
         $this->logger = $logger;
         // determine whether to use OpenSSL
@@ -30,10 +27,6 @@ public function __construct(LoggerInterface $logger = null)
         }
     }
 
-    /**
-     * @param int $nbBytes
-     * @return string
-     */
     public function getRandomNumber(int $nbBytes = 32): string
     {
         // try OpenSSL