Fixed bug where dismissing a presentedViewController would force RNSwipeViewController to unexpectedly revert to its centerViewController #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…that method was called while its visibleController was dismissing a presentedViewController
…tting it to true prevents the swipeController from switching to another sub-controller until it is reset back to false or one of the canShowRight, canShowLeft, canShowBottom properties is explicitly set to true.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran into an issue where, after running presentViewController and subsequently dismissViewControlller from RNSwipeViewController's rightViewController, the RNSwipeViewController would force itself back to displaying centerViewController instead of sticking with the rightViewController. RNSwipeViewController will now suppress its viewWillAppear method if a presentedViewController is in the process of being dismissed.