Support cyclic references #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fe loader is already enabled If we get a `RecursionError` in this case, something else must have gone wrong
|
@dlenski Thanks for your work on this! I’ve been wanting to add support for cyclic references myself, but ran out of time. Since all tests look good, I’ll go ahead and merge this into the main branch. I’ll include these changes along with my updates in #139 for the next minor release, Thanks again, and hope your week (or weekend!) is going well. |
rnag
added a commit
that referenced
this pull request
Nov 9, 2024
rnag
added a commit
that referenced
this pull request
Nov 10, 2024
* bump * minor fix * minor fix * Add test case to satisfy #89 * Support cyclic references (#138) * support cyclic or self-referential dataclasses * update to add custom recursion error * Don't replace RecursionError with RecursiveClassError if recursion-safe loader is already enabled If we get a `RecursionError` in this case, something else must have gone wrong --------- Co-authored-by: Ritvik Nag <[email protected]> * Update all requirements to latest versions * Update requirements in requirements-dev.txt and requirements-test.txt to latest * "When you drop py3.6/7/8, remove everything EXCEPT the py.typed file." * See [comment](#136 (comment)) * Update tests to support Python 3.9+ * Run tests on CI for PY 3.9+ * `typing_extensions` should be required for Python 3.10 (as well as 3.9) * Starting to purge PY 3.6, 3.7 and 3.8 support * Fix `Sphinx` dependency issue * I realized this was a bug! * Continue with purge of PY 3.6, 3.7, and 3.8 * Continue with purge of PY 3.6, 3.7, and 3.8 * Continue with purge of PY 3.6, 3.7, and 3.8 * This concludes the purge of PY 3.6, 3.7, and 3.8 * Remove unnecessary code * Remove unnecessary code * Update docs to mention cyclic or "recursive" dataclasses * Update docs to remove `typing.List` mentions * Update docs to remove `typing.List` mentions * Update HISTORY.rst --------- Co-authored-by: Dan Lenski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased old branch https://github.com/rnag/dataclass-wizard/tree/WIP-support-cyclic-references (from #62) onto
mainAdded 22060e6 to ensure that
RecursiveClassErrorisn't shown in misleading cases.