Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit test for repo.getterImpl (and file:// scheme support) #64

Merged
merged 2 commits into from
Oct 6, 2023

Conversation

wwade
Copy link
Contributor

@wwade wwade commented Oct 6, 2023

Pull request #63 added support for the file:// scheme for fetch. This change adds the suggested test case to ensure that both the baseline http:// support and the newly-added file:// support are working as expected.

Pull request rmohr#63 added support for the `file://` scheme for `fetch`.
This change adds the suggested test case to ensure that both the
baseline `http://` support and the newly-added `file://` support are
working as expected.
Copy link
Owner

@rmohr rmohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Can it be that make gazelle needs to be run to generate the build files?

Ran `make gazelle` to recalculate the go_test targets.
@wwade
Copy link
Contributor Author

wwade commented Oct 6, 2023

Thank you! Can it be that make gazelle needs to be run to generate the build files?

Done!

Copy link
Owner

@rmohr rmohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Thank!

@rmohr rmohr merged commit 6ce8d7f into rmohr:main Oct 6, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants