Silently drop wl where sensdata is 0 if required #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice one — cheers. Look good to me. |
Bisaloo
commented
Jun 12, 2020
| @@ -279,14 +275,14 @@ vismodel <- function(rspecdata, | |||
| illum <- bgil[, grep(illum2, names(bgil))] | |||
| } | |||
| if (illum2 == "ideal") { | |||
| illum <- rep(1, dim(rspecdata)[1]) | |||
| illum <- rep_len(1, 401) | |||
There was a problem hiding this comment.
Hum, now that I think about it, there is an issue with this since the user could provide a user-defined S that has the correct length to match the data but still rely on bundled values for other arguments. In this case, the new if branch would never be explored and we would end up the illum having the wrong length
Bisaloo
force-pushed
the
vismodel-wl
branch
from
2a4347c
to
a8004f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #74