added code for http session handling, and code refactorization #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Eric, The question you are talking about requests lib, maybe its a version difference. Yes, its old, I know. :) |
|
About the changes because JSON parse is almost the same, I know, but for organization I kept it separated. Tks for collaboration |
|
Le 2018-04-18 12:47, Rodrigo Kellermann Ferreira a écrit :
Hi Eric,
Tks for reviewing this project.
The question you are talking about requests lib, maybe its a version difference.
I'm running this script as it is on:
python26-requests-0.13.1-1.el5
python26-argparse-1.2.1-3.el5
Yep, Python 2.6 is deprecated and should be used anymore :)
This probably explains the different behavior I experienced. I wonder
many other nagios users might experience the same, unless they're
running very old nagios setup...
Regards,
…--
Eric
|
|
Le 2018-04-18 12:56, Rodrigo Kellermann Ferreira a écrit :
About the changes because JSON parse is almost the same, I know, but for organization I kept it separated.
It's up to you ;)
Personally I prefer of course my version: I like factorization :-p
Seriously it's easier to maintain, and IMHO more readable. I'll keep my
fork but I'll keep an eye on your branch anyway.
By the way, thanks again for your initial work as it provided to me all
the materials I needed to monitor this shitty EMC² enclosure :D
regards,
…--
Eric [1]
Links:
------
[1]
https://webmail.ricozome.net/?_task=mail&_action=compose&_id=14242223075ad732575e9bf&_extwin=1#
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I tried to use your script but I wasn't able to use it as is. After a bit of troubleshooting it appeared that the session cookies were not followed after the initial login and the actual GET for health information.
I'm not a Python expert but I wondered you misused the requests library as you didn't made usage of requests.Session object, so I modified your code to do so, and this fixed my issue.
I also made a huge code refactorization as the JSON parsing is almost always the same.
Many thanks for your inital work, I hope you'll enjoy my modifications.
Kind regards,
Eric