Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pnpm and Nx to manage the monorepo #4275

Draft
wants to merge 1 commit into
base: rjsf-v6
Choose a base branch
from

Conversation

nickgros
Copy link
Contributor

@nickgros nickgros commented Aug 16, 2024

TODO: Set up CI for v6
TODO: Test publishing and ensure release scripts work

Reasons for making this change

Fixes #3965

  • Use pnpm for package management
  • Improves developer experience by allowing us to reference workspace package dependencies that are replaced at publish-time, removing the need to release new versions just for the sake of upgrading peer dependencies ()
  • Improves developer experience by being faster than npm
  • Fully use Nx for monorepo management (drop Lerna aliases, which just used Nx under the hood)

Checklist

  • I'm updating documentation
  • I'm adding or updating code
    • I've added and/or updated tests. I've run npx nx run-many --target=build --exclude=@rjsf/docs && npm run test:update to update snapshots, if needed.
    • I've updated docs if needed
    • I've updated the changelog with a description of the PR
  • I'm adding a new feature
    • I've updated the playground with an example use of the feature

- Use pnpm for package management
  - Improves developer experience by allowing us to reference workspace package dependencies that are replaced at publish-time, removing the need to release new versions just for the sake of upgrading peer dependencies ()
  - Improves developer experience by being faster than npm
- Fully use Nx for monorepo management (drop Lerna aliases, which just used Nx under the hood)
@nickgros nickgros changed the base branch from main to rjsf-v6 August 18, 2024 14:48
@nickgros nickgros marked this pull request as ready for review August 18, 2024 14:48
@nickgros nickgros marked this pull request as draft August 18, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant