Mark matchdoc as broken

Always get a 404 back from ADS
rjfarmer · Aug 16, 2022 · ed0684c · ed0684c
1 parent 95ff35d
commit ed0684c
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 183 deletions.
diff --git a/src/pyastroapi/api/recommender.py b/src/pyastroapi/api/recommender.py
@@ -3,6 +3,8 @@
 from . import urls
 from . import http
 
+import typing as t
+
 __all__ = ["matchdoc", "similar", "trending", "reviews", "useful"]
 
 
@@ -13,8 +15,8 @@ def matchdoc(
     author: str = "",
     year: int = "",
     doctype: str = "article",
-    match_doctype=["article"],
-    must_match=False,
+    match_doctype: t.List[str] = ["article"],
+    must_match=True,
 ):
     url = urls.make_url(urls.urls["oracle"]["match"])
 
@@ -27,7 +29,9 @@ def matchdoc(
     data["match_doctype"] = match_doctype
     data["mustmatch"] = must_match
 
-    r = http.post(token, url, data=data)
+    r = http.post(token, url, data=data, json=True)
+
+    print(r)
 
     if r.status != 200:
         raise e.AdsApiError(r.response["error"])

diff --git a/tests/cassettes/TestAPIRecommend.test_matchdoc.yaml b/tests/cassettes/TestAPIRecommend.test_matchdoc.yaml
diff --git a/tests/test_api.py b/tests/test_api.py
@@ -553,6 +553,7 @@ def test_word_cloud(self):
 
 @pytest.mark.vcr()
 class TestAPIRecommend:
+    @pytest.mark.skip(reason="Broken")
     def test_matchdoc(self):
 
         r = recommend.matchdoc(