Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add append char functionality #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ahansen90
Copy link

@ahansen90 ahansen90 commented Apr 3, 2017

Hey, I like this plugin but wanted a counterpart to the insert mapping ala i/a. I also added a check that checks for "append_char_no_default_mapping" much like yours does for insert. I changed the mapping for insert to be underscore and for the new append to be a dash. I can change it to something else if you like.

Copy link
Owner

@rjayatilleka rjayatilleka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, this looks good! Thanks for the addition. I left one comment. If you switch that, I'd be happy to merge it in. Thanks!


if !exists('g:insert_char_no_default_mapping') || (g:insert_char_no_default_mapping == 0)
nmap <Space> <Plug>InsertChar
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's leave this as <Space>. It's not wise to change existing defaults without a good reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants