Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove links to empty placeholder queue detail page #10

Merged
merged 1 commit into from
May 23, 2024
Merged

remove links to empty placeholder queue detail page #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 2 additions & 10 deletions ui/src/components/JobDetail.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ import { capitalize } from "@utils/string";
import clsx from "clsx";
import JobTimeline from "./JobTimeline";
import { FormEvent, useMemo, useState } from "react";
import { Link } from "@tanstack/react-router";
import TopNavTitleOnly from "./TopNavTitleOnly";
import RelativeTimeFormatter from "./RelativeTimeFormatter";
import JobAttemptErrors from "./JobAttemptErrors";
Expand Down Expand Up @@ -118,7 +117,6 @@ export default function JobDetail({ cancel, job, retry }: JobDetailProps) {
</h1>
<p className="mt-2 text-base leading-6 text-slate-600 dark:text-slate-400">
ID: <span className="font-mono">{job.id.toString()}</span>
{/* {capitalize(job.state)} */}
</p>
</div>
<div className="order-none flex w-full justify-around sm:block sm:w-auto sm:flex-none">
Expand Down Expand Up @@ -159,14 +157,8 @@ export default function JobDetail({ cancel, job, retry }: JobDetailProps) {
<dt className="text-sm font-medium leading-6 text-slate-900 dark:text-slate-100">
Queue
</dt>
<dd className="mt-1 flex overflow-hidden text-sm leading-6 text-slate-700 dark:text-slate-300 sm:mt-2">
<Link
to="/queues/$name"
className="font-mono text-sm font-semibold leading-6 text-slate-900"
params={{ name: job.queue }}
>
{job.queue}
</Link>
<dd className="mt-1 flex overflow-hidden font-mono text-sm leading-6 text-slate-700 dark:text-slate-300 sm:mt-2">
{job.queue}
</dd>
</div>
<div className="col-span-6 border-t border-slate-100 px-4 py-6 dark:border-slate-800 sm:px-0">
Expand Down
25 changes: 10 additions & 15 deletions ui/src/components/QueueList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import { Queue } from "@services/queues";
import { PauseCircleIcon, PlayCircleIcon } from "@heroicons/react/24/outline";
import { Link } from "@tanstack/react-router";
import TopNavTitleOnly from "@components/TopNavTitleOnly";
import RelativeTimeFormatter from "@components/RelativeTimeFormatter";

Expand Down Expand Up @@ -69,22 +68,10 @@ const QueueList = ({
{queues.map((queue) => (
<tr key={queue.name}>
<td className="w-full max-w-0 py-4 pl-4 pr-3 text-sm font-medium text-slate-900 dark:text-slate-100 sm:w-auto sm:max-w-none sm:pl-0">
<Link
className="font-mono"
to="/queues/$name"
params={{ name: queue.name }}
>
<span className="font-mono font-semibold text-slate-700 dark:text-slate-300">
{queue.name}
</Link>
</span>
<dl className="font-normal md:hidden">
<dt className="sr-only">Created</dt>
<dd className="mt-1 truncate text-slate-700 dark:text-slate-300">
<RelativeTimeFormatter
time={queue.createdAt}
addSuffix
includeSeconds
/>
</dd>
<dt className="sr-only sm:hidden">Available</dt>
<dd className="mt-1 truncate text-slate-700 dark:text-slate-300 sm:hidden">
{queue.countAvailable} available
Expand All @@ -93,6 +80,14 @@ const QueueList = ({
<dd className="mt-1 truncate text-slate-700 dark:text-slate-300 sm:hidden">
{queue.countRunning} running
</dd>
<dt className="sr-only">Created</dt>
<dd className="mt-1 truncate text-slate-700 dark:text-slate-300">
<RelativeTimeFormatter
time={queue.createdAt}
addSuffix
includeSeconds
/>
</dd>
</dl>
</td>
<td className="hidden px-3 py-4 text-right text-sm text-slate-500 dark:text-slate-400 md:table-cell">
Expand Down
Loading