Skip to content

Commit

Permalink
remove links to empty placeholder queue detail page
Browse files Browse the repository at this point in the history
  • Loading branch information
bgentry committed May 23, 2024
1 parent 634160d commit 09853c8
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 23 deletions.
11 changes: 2 additions & 9 deletions ui/src/components/JobDetail.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,6 @@ export default function JobDetail({ cancel, job, retry }: JobDetailProps) {
</h1>
<p className="mt-2 text-base leading-6 text-slate-600 dark:text-slate-400">
ID: <span className="font-mono">{job.id.toString()}</span>
{/* {capitalize(job.state)} */}
</p>
</div>
<div className="order-none flex w-full justify-around sm:block sm:w-auto sm:flex-none">
Expand Down Expand Up @@ -159,14 +158,8 @@ export default function JobDetail({ cancel, job, retry }: JobDetailProps) {
<dt className="text-sm font-medium leading-6 text-slate-900 dark:text-slate-100">
Queue
</dt>
<dd className="mt-1 flex overflow-hidden text-sm leading-6 text-slate-700 dark:text-slate-300 sm:mt-2">
<Link
to="/queues/$name"
className="font-mono text-sm font-semibold leading-6 text-slate-900"
params={{ name: job.queue }}
>
{job.queue}
</Link>
<dd className="mt-1 flex overflow-hidden font-mono text-sm leading-6 text-slate-700 dark:text-slate-300 sm:mt-2">
{job.queue}
</dd>
</div>
<div className="col-span-6 border-t border-slate-100 px-4 py-6 dark:border-slate-800 sm:px-0">
Expand Down
24 changes: 10 additions & 14 deletions ui/src/components/QueueList.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -69,22 +69,10 @@ const QueueList = ({
{queues.map((queue) => (
<tr key={queue.name}>
<td className="w-full max-w-0 py-4 pl-4 pr-3 text-sm font-medium text-slate-900 dark:text-slate-100 sm:w-auto sm:max-w-none sm:pl-0">
<Link
className="font-mono"
to="/queues/$name"
params={{ name: queue.name }}
>
<span className="font-mono font-semibold text-slate-700 dark:text-slate-300">
{queue.name}
</Link>
</span>
<dl className="font-normal md:hidden">
<dt className="sr-only">Created</dt>
<dd className="mt-1 truncate text-slate-700 dark:text-slate-300">
<RelativeTimeFormatter
time={queue.createdAt}
addSuffix
includeSeconds
/>
</dd>
<dt className="sr-only sm:hidden">Available</dt>
<dd className="mt-1 truncate text-slate-700 dark:text-slate-300 sm:hidden">
{queue.countAvailable} available
Expand All @@ -93,6 +81,14 @@ const QueueList = ({
<dd className="mt-1 truncate text-slate-700 dark:text-slate-300 sm:hidden">
{queue.countRunning} running
</dd>
<dt className="sr-only">Created</dt>
<dd className="mt-1 truncate text-slate-700 dark:text-slate-300">
<RelativeTimeFormatter
time={queue.createdAt}
addSuffix
includeSeconds
/>
</dd>
</dl>
</td>
<td className="hidden px-3 py-4 text-right text-sm text-slate-500 dark:text-slate-400 md:table-cell">
Expand Down

0 comments on commit 09853c8

Please sign in to comment.