Check tag format + return metadata + additional doc strings #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandur
changed the title
require statements to client initialization example
brandur
force-pushed
the
brandur-tag-format-metadata
branch
from
7231c0b to
a33e459
Compare
Mainly, bring in tag format checks which verify they're shorter than 255 characters and don't contain any special characters (especially commas), like Go and Python do already. Start returning metadata in jobs, although notably, it's not possible to insert with it yet. A few additional docstrings brought over from my project to document River Python.
brandur
force-pushed
the
brandur-tag-format-metadata
branch
from
a33e459 to
d62a407
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mainly, bring in tag format checks which verify they're shorter than 255
characters and don't contain any special characters (especially commas),
like Go and Python do already.
Start returning metadata in jobs, although notably, it's not possible to
insert with it yet.
A few additional docstrings brought over from my project to document
River Python.