Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update MaxWorkers behaviour as it propagates down to the producer #647

Conversation

kamikazechaser
Copy link
Contributor

refs:

*https://github.com/riverqueue/river/blob/master/producer.go#L598

I think this makes it clear on how the max workers value should be tuned based on the job type.

@bgentry
Copy link
Contributor

bgentry commented Oct 25, 2024

Hi @kamikazechaser, from looking at this I'm not quite sure what's missing from the original explanation that is made more clear with this change. The statement that MaxWorkers corresponds to max parallelism for the client seems concise and correct to me, without getting into internal details like the concept of an executor.

Can you maybe elaborate on what you think is missing from the original explanation? Would still like to improve this further if possible. Thanks.

@bgentry bgentry closed this Oct 25, 2024
@kamikazechaser
Copy link
Contributor Author

without getting into internal details like the concept of an executor.

It was related to some question in one of the issues. But looking back at it now, it makes sense not to get into the internals of how the MaxWorkers option is utilized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants