Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InsertManyFast doc fixes for uniqueness #609

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

bgentry
Copy link
Contributor

@bgentry bgentry commented Sep 23, 2024

I missed this documentation change in #590. InsertManyFast / InsertManyFastTx do support unique jobs now, just not as gracefully as the other InsertMany methods.

@bgentry bgentry requested a review from brandur September 23, 2024 01:25
@bgentry bgentry force-pushed the bg-insert-many-fast-doc-fixes branch from 3b71780 to fb8cf90 Compare September 23, 2024 01:27
@bgentry
Copy link
Contributor Author

bgentry commented Sep 23, 2024

Minor doc fix I separated out for visibility, but I don't think it needs to block on review. Feel free to follow up with tweaks/suggestions/objections/etc ✌️

@bgentry bgentry merged commit 185dbb8 into master Sep 23, 2024
14 checks passed
@bgentry bgentry deleted the bg-insert-many-fast-doc-fixes branch September 23, 2024 02:09
tigrato pushed a commit to gravitational/river that referenced this pull request Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant