move testfactory to rivershared #587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will be useful for tests in other River libraries (riverui, riverpro).
brandur
approved these changes
Sep 10, 2024
There was a problem hiding this comment.
Damn that replace thing is absurd. (Odd that I don't remember running into this at all during development, but I guess it's because I never ran go mod tidy, and nothing complained that I should.)
Yet another run on Go workspace thread on the problem with no clear resolution in sight:
tigrato
pushed a commit
to gravitational/river
that referenced
this pull request
Dec 18, 2024
This will be useful for tests in other River libraries (riverui, riverpro).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be useful for tests in other River libraries (riverui, riverpro).
The
replacein here is necessary to avoid issues withgo mod tidytrying to fetch theriversharedmodule from remote and it not containing thetestfactorypackage. I believe we should be able to simply remove it prior to release, but you may have more insight on that given the workspace testing you did.