Fix nil periodic jobs #572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes an issue with the PerioridJobConstructor ignoring the return value. According to the docs, we should ignore the job is nil is returned.
bgentry
force-pushed
the
fix-nil-periodic-jobs
branch
2 times, most recently
from
5dc0004 to
c10df06
Compare
bgentry
force-pushed
the
fix-nil-periodic-jobs
branch
from
c10df06 to
31afef4
Compare
brandur
approved these changes
Aug 30, 2024
tigrato
pushed a commit
to gravitational/river
that referenced
this pull request
Dec 18, 2024
* Do not insert a new job if PeriodicJobConstructor returns nil This commit fixes an issue with the PerioridJobConstructor ignoring the return value. According to the docs, we should ignore the job is nil is returned. * Remove unused struct * add client-level test coverage for PeriodicJobConstructor nil return --------- Co-authored-by: Andriy Semenets <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes #567 with some additional coverage and a lint fix.
Closes #567.