Fix subscription stress test in notifier #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While I was trying to fix another problem in the notifier's subscription stress test, I ended up introducing another one by using a single wait group for both the notification sending goroutine and subscriptions loops which caused the test intermittency described in #268. The test was ending too soon, and channels would only receive 1-2 messages, and sometimes zero (which would fail the test). notifier_test.go:462: Channel 0 contains 2 message(s) notifier_test.go:462: Channel 1 contains 2 message(s) notifier_test.go:462: Channel 2 contains 2 message(s) notifier_test.go:462: Channel 3 contains 2 message(s) notifier_test.go:462: Channel 4 contains 2 message(s) notifier_test.go:462: Channel 5 contains 2 message(s) notifier_test.go:462: Channel 6 contains 2 message(s) notifier_test.go:462: Channel 7 contains 0 message(s) Here, fix the problem by putting in different symbols for the notification send and subscription loops. The proper order of operations to finish the test are: 1. Wait for all subscription groups to finish. 2. Tell the notification send loop to shut down. 3. Wait for the notification send loop to return (so as not to introduce any goroutine leaks like had been present before). Fixes #268.
brandur
commented
Mar 13, 2024
| @@ -454,9 +455,9 @@ func TestNotifier(t *testing.T) { | |||
| }() | |||
| } | |||
|
|
|||
| close(shutdown) | |||
| wg.Wait() | |||
| notifier.Stop() | |||
There was a problem hiding this comment.
Notifier was already stopping in a t.Cleanup above, so this invocation wasn't necessary.
bgentry
approved these changes
Mar 13, 2024
|
ty. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I was trying to fix another problem in the notifier's subscription
stress test, I ended up introducing another one by using a single wait
group for both the notification sending goroutine and subscriptions
loops which caused the test intermittency described in #268. The test
was ending too soon, and channels would only receive 1-2 messages, and
sometimes zero (which would fail the test).
Here, fix the problem by putting in different symbols for the
notification send and subscription loops. The proper order of operations
to finish the test are:
any goroutine leaks like had been present before).
Fixes #268.