Add rivertype module to release instructions
#244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of #212, `rivertype` became a separate Go module from the mainline `river`. Here, add it to the release instructions so that it gets properly tagged along with other all other modules. Also add it to the `update-submodule-versions` program. This isn't strictly necessary because `rivertype` doesn't have any submodule versions to update, but it feels like it should be there for completeness just in case, and also because it makes the list in the program a complete list of all Go modules in the project.
bgentry
approved these changes
Mar 1, 2024
|
ty! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of #212,
rivertypebecame a separate Go module from the mainlineriver. Here, add it to the release instructions so that it getsproperly tagged along with other all other modules.
Also add it to the
update-submodule-versionsprogram. This isn'tstrictly necessary because
rivertypedoesn't have any submoduleversions to update, but it feels like it should be there for
completeness just in case, and also because it makes the list in the
program a complete list of all Go modules in the project.