Add .rv32 on rv32_zbs and rv32_zbb instructions
#220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to be consistent with slli, srli, and srai. Signed-off-by: Hiroo HAYASHI <[email protected]>
- zext.h.rv32, rev8.rv32, and rori.rev32
- rev8.rv32, and rori.rev32 are also aliased in rv32_{zk,zkn,zks,zbkb}
- only rv32_zks is shown in the extension field
Signed-off-by: Hiroo HAYASHI <[email protected]>
hirooih
force-pushed
the
rv32-pseudo-ops
branch
from
cafe798
to
d3e1af0
Compare
aswaterman
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
shamt[5]must be 0 for RV32.slli.rv32, etc., are defined forslli,srli, andsraito address this issue.bclri,bexti,binvi,bseti, androrihave same issue. This PR adds.rv32for them.Similarly
zext.handrev8have different encoding for RV32 and RV64. Only RV64 versions are emitted in output files. This PR also adds.rv32for them to solve this.Note:
rev8androriare aliased inrv32_{zk,zkn,zks}. But onlyrv32_zksis shown in theextensionfield ininstr_dict.yaml. I think this is an issue ofparse.py.