Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split dret from rv_system to rv_debug #197

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

sequencer
Copy link
Contributor

Because neither priv and unpriv isa mentions dret, and debug is lived in
a standalone spec, move dret out from rv_system, while putting it into
rv_debug

Because neither priv and unpriv isa mentions dret, and debug is lived in
a standalone spec, move dret out from rv_system, while putting it into
rv_debug
Copy link
Member

@aswaterman aswaterman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reasonable.

@aswaterman aswaterman merged commit a3333df into riscv:master Sep 27, 2023
2 checks passed
@neelgala
Copy link
Collaborator

shouldn't the extension be rv_sdext (as per the debug spec)

@sequencer
Copy link
Contributor Author

shouldn't the extension be rv_sdext (as per the debug spec)

agree, I think rv_sdext should live as "Debug ISA" as part of

Machine ISA
Supervisor ISA
Svnapot Extension
Svpbmt Extension
Svinval Extension
Hypervisor ISA

@neelgala
Copy link
Collaborator

@sequencer can you raise another PR to rename rv_debug to rv_sdext ?

@sequencer
Copy link
Contributor Author

Done in #198 cc @neelgala.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants