mnxti pseudo code clarification when rs1 == x0 #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it is confusing when doing csrr (rs1 == x0) whether clic.level should be compared against mcause.mpil or whether it should be compared to 0 (rs1[23:16]). I think the intent is that csr reads are compared to mcause.mpil. Signed-off-by: Dan Smathers <[email protected]>
rpsene
force-pushed
the
master
branch
3 times, most recently
from
faa80cf to
456d4c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it is confusing when doing csrr (rs1 == x0) whether clic.level should be compared against mcause.mpil or whether it should be compared to 0 (rs1[23:16]). I think the intent is that csr reads are compared to mcause.mpil.