Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI/CD: Switch from gzip to XZ for archive compression #1606

Closed
wants to merge 1 commit into from

Conversation

cmuellner
Copy link
Collaborator

To reduce the disk space consumption and upload/download times, let's switch to a better archrive compression algorithm. XZ should be popular enough to not cause many complaints about this.

To reduce the disk space consumption and upload/download times,
let's switch to a better archrive compression algorithm.
XZ should be popular enough to not cause many complaints about this.

Signed-off-by: Christoph Müllner <[email protected]>
Copy link
Collaborator

@TommyMurphyTM1234 TommyMurphyTM1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments...

@@ -63,7 +63,7 @@ jobs:
sudo du -hs / 2> /dev/null || true

- name: tarball build
run: tar czvf riscv.tar.gz -C /opt/ riscv/
run: XZ_OPT="--threads=0 -6e" tar cJf riscv.tar.xz -C /opt/ riscv/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious - how were the XZ_OPT options chosen?
Why --threads=0? Does "parallel" processing cause problems with the resulting output?
Isn't -6 compression level the default anyway so why specify it explicitly?

Could the XZ_OPT settings be specified once and reused elsewhere so that if they ever need to be tweaked it is just a single line change?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When T=0 xz uses all available cores/hardware threads, -e means extreme (so it's not 6 which is the default but 6e).

@mickflemm
Copy link
Contributor

This 37d2c54 also changes the mime type from gzip to x-xz and creates the tarball before make_report so that it doesn't include qemu/dejagnu etc.

@kito-cheng
Copy link
Collaborator

Close since #1608 has merged and that has included this change as well

@kito-cheng kito-cheng closed this Nov 22, 2024
jserv added a commit to sysprog21/rv32emu that referenced this pull request Nov 25, 2024
Ubuntu's GNU tar supports multiple compression formats [1], allowing us
to extract both gzip and XZ archives using the same command, reflecting
the riscv-gnu-toolchain's recent compression format change [2].

[1] https://www.gnu.org/software/tar/manual/tar.html#SEC131
[2] riscv-collab/riscv-gnu-toolchain#1606
ChinYikMing pushed a commit to ChinYikMing/rv32emu that referenced this pull request Dec 14, 2024
Ubuntu's GNU tar supports multiple compression formats [1], allowing us
to extract both gzip and XZ archives using the same command, reflecting
the riscv-gnu-toolchain's recent compression format change [2].

[1] https://www.gnu.org/software/tar/manual/tar.html#SEC131
[2] riscv-collab/riscv-gnu-toolchain#1606
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants