-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI/CD: Switch from gzip to XZ for archive compression #1606
Conversation
To reduce the disk space consumption and upload/download times, let's switch to a better archrive compression algorithm. XZ should be popular enough to not cause many complaints about this. Signed-off-by: Christoph Müllner <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments...
@@ -63,7 +63,7 @@ jobs: | |||
sudo du -hs / 2> /dev/null || true | |||
|
|||
- name: tarball build | |||
run: tar czvf riscv.tar.gz -C /opt/ riscv/ | |||
run: XZ_OPT="--threads=0 -6e" tar cJf riscv.tar.xz -C /opt/ riscv/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious - how were the XZ_OPT
options chosen?
Why --threads=0
? Does "parallel" processing cause problems with the resulting output?
Isn't -6
compression level the default anyway so why specify it explicitly?
Could the XZ_OPT
settings be specified once and reused elsewhere so that if they ever need to be tweaked it is just a single line change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When T=0 xz uses all available cores/hardware threads, -e means extreme (so it's not 6 which is the default but 6e).
This 37d2c54 also changes the mime type from gzip to x-xz and creates the tarball before make_report so that it doesn't include qemu/dejagnu etc. |
Close since #1608 has merged and that has included this change as well |
Ubuntu's GNU tar supports multiple compression formats [1], allowing us to extract both gzip and XZ archives using the same command, reflecting the riscv-gnu-toolchain's recent compression format change [2]. [1] https://www.gnu.org/software/tar/manual/tar.html#SEC131 [2] riscv-collab/riscv-gnu-toolchain#1606
Ubuntu's GNU tar supports multiple compression formats [1], allowing us to extract both gzip and XZ archives using the same command, reflecting the riscv-gnu-toolchain's recent compression format change [2]. [1] https://www.gnu.org/software/tar/manual/tar.html#SEC131 [2] riscv-collab/riscv-gnu-toolchain#1606
To reduce the disk space consumption and upload/download times, let's switch to a better archrive compression algorithm. XZ should be popular enough to not cause many complaints about this.