-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: STARK to SNARK conversion with Bonsai #86
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wollac
approved these changes
Feb 12, 2024
host/src/main.rs
Outdated
@@ -39,35 +41,70 @@ async fn main() -> Result<()> { | |||
info!(" op-derive: {}", Digest::from(OP_DERIVE_ID)); | |||
info!(" op-compose: {}", Digest::from(OP_COMPOSE_ID)); | |||
|
|||
// Prevent internal prover from calling Bonsai on its own |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is that still needed? I was hoping, that this is also fixed with #91
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah I think it should be okay since #91 does not instantiate the default prover
hashcashier
force-pushed
the
rkhalil/stark2snark
branch
from
February 12, 2024 17:14
c14ef25
to
7f7f122
Compare
johntaiko
pushed a commit
to johntaiko/zeth
that referenced
this pull request
Apr 10, 2024
feat: Input cache & remove unused components
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the
--snark
flag to theprove
command, which converts (and validates) the final STARK output of the command into a SNARK using Bonsai. when using--snark
, the--verifier-contract
parameter must also be set to the on-chain address of the contract to use for validation. Additionally, a--verifier-rpc-url
parameter can also be set to use a different rpc node than the one specified ineth-rpc-url
.Note: This PR does not update the README to explain these parameters to keep them in an experimental state.