Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: STARK to SNARK conversion with Bonsai #86

Merged
merged 201 commits into from
Feb 12, 2024
Merged

Conversation

hashcashier
Copy link
Contributor

@hashcashier hashcashier commented Feb 1, 2024

This PR introduces the --snark flag to the prove command, which converts (and validates) the final STARK output of the command into a SNARK using Bonsai. when using --snark, the --verifier-contract parameter must also be set to the on-chain address of the contract to use for validation. Additionally, a --verifier-rpc-url parameter can also be set to use a different rpc node than the one specified in eth-rpc-url.

Note: This PR does not update the README to explain these parameters to keep them in an experimental state.

@hashcashier hashcashier marked this pull request as ready for review February 7, 2024 10:25
host/src/main.rs Outdated
@@ -39,35 +41,70 @@ async fn main() -> Result<()> {
info!(" op-derive: {}", Digest::from(OP_DERIVE_ID));
info!(" op-compose: {}", Digest::from(OP_COMPOSE_ID));

// Prevent internal prover from calling Bonsai on its own
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that still needed? I was hoping, that this is also fixed with #91

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah I think it should be okay since #91 does not instantiate the default prover

Base automatically changed from rkhalil/op-compose to main February 12, 2024 16:28
@hashcashier hashcashier merged commit 8014722 into main Feb 12, 2024
4 checks passed
@hashcashier hashcashier deleted the rkhalil/stark2snark branch February 12, 2024 17:41
@hashcashier hashcashier restored the rkhalil/stark2snark branch February 12, 2024 17:41
johntaiko pushed a commit to johntaiko/zeth that referenced this pull request Apr 10, 2024
feat: Input cache & remove unused components
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants