-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean-up guest builds #62
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the Cargo.lock
it seems to work, but I do not understand the details:
- The TOML still contains
[target.'cfg(not(target_os = "zkvm"))'.dependencies]
. So this is still needed, but simply adding the optional will do the trick? - Building the lib with
--no-default-features
now fails because the target OS is notzkvm
, but all those dependencies are not included. This also causes problems with the rust-analyzer. Is there a way to fix this? One alternative I could think of is to remove all#[cfg(not(target_os = "zkvm"))]
and manually enable/disable thehost
feature. However, I am not sure if this is a good idea.
Yeah I'm not sure why Overall this is just a suggestion, maybe a bit hacky, so no harm in closing it if you guys are not convinced. Obviously would be better to understand why |
Actually I did not feel comfortable at removing the |
It seems that |
* Refactor MptNode struct and methods * fix: avoid RefCell cross-await
As the
[target.'cfg(not(target_os = "zkvm"))'.dependencies]
does not seem to work for some reason, this PR exposes the featurehost
(enabled by default) to prevent unnecessary deps ending up in the guest builds