Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply dotnet format #869

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Apply dotnet format #869

merged 1 commit into from
Nov 7, 2023

Conversation

trejjam
Copy link
Contributor

@trejjam trejjam commented Nov 4, 2023

Apply dotnet format

Description

File encoding was not uniform. Now it honors configuration from .editorconfig

Checklist

  • The existing code style is followed
  • The commit message follows our guidelines
  • Performed a self-review of my code
  • Hard-to-understand areas of my code are commented
  • The documentation is updated (as applicable)
  • Unit tests are added/updated
  • Integration tests are added/updated (as applicable, especially if feature/bug depends on roslyn or framework version in use)

Copy link

codecov bot commented Nov 4, 2023

Codecov Report

Merging #869 (60e49d2) into main (a8acc04) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #869   +/-   ##
=======================================
  Coverage   91.45%   91.45%           
=======================================
  Files         214      214           
  Lines        7149     7149           
  Branches      867      867           
=======================================
  Hits         6538     6538           
  Misses        406      406           
  Partials      205      205           
Files Coverage Δ
...stractions/MapperIgnoreObsoleteMembersAttribute.cs 100.00% <ø> (ø)
...rly.Abstractions/MapperRequiredMappingAttribute.cs 100.00% <ø> (ø)
...numerables/EnsureCapacity/EnsureCapacityBuilder.cs 68.00% <ø> (ø)
...s/Enumerables/EnsureCapacity/EnsureCapacityInfo.cs 100.00% <ø> (ø)
...Enumerables/EnsureCapacity/EnsureCapacityMember.cs 100.00% <ø> (ø)
...bles/EnsureCapacity/EnsureCapacityNonEnumerated.cs 100.00% <ø> (ø)
...erContext/NewValueTupleExpressionBuilderContext.cs 100.00% <ø> (ø)
...appingBuilders/DateTimeToDateOnlyMappingBuilder.cs 60.00% <ø> (ø)
...appingBuilders/DateTimeToTimeOnlyMappingBuilder.cs 60.00% <ø> (ø)
...escriptors/MappingBuilders/MemoryMappingBuilder.cs 88.46% <ø> (ø)
... and 17 more

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@trejjam
Copy link
Contributor Author

trejjam commented Nov 4, 2023

Related conversation: #864 (comment)

@trejjam
Copy link
Contributor Author

trejjam commented Nov 4, 2023

It seems that csharpier does not enforce file encoding. Which is probably a root cause of this

@latonz latonz merged commit 5bd3fdd into riok:main Nov 7, 2023
19 checks passed
@trejjam trejjam deleted the fix/code-style branch November 7, 2023 12:58
Copy link

🎉 This PR is included in version 3.3.0-next.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link

🎉 This PR is included in version 3.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants