fix: initialize nullable members for nested containers #1660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
latonz
requested changes
Jan 6, 2025
Comment on lines
+96
to
+97
| if (_initializedNullableTargetPaths.Contains((Mapping, nullablePath))) | ||
| continue; |
There was a problem hiding this comment.
This additional contains call is not needed, is it?
| @@ -588,6 +588,45 @@ public partial B Map(A a) | |||
| ); | |||
| } | |||
|
|
|||
| [Fact] | |||
| public void NullableNestedMembersShouldInitializeWithNoNullAssignment() | |||
There was a problem hiding this comment.
Could you also create a test case for this slightly different one: #1661 (initialization after the if, but outside of any if)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: initialize nullable members for nested containers
Description
Made changes to store
IMemberAssignmentMappingContaineralong with theMemberPathto keep track of nullable member initializations.Fixes #1650
Checklist