Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue #72 #105

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

TaleirOfDeynai
Copy link

The issue this resolves was closed without resolution, but it was bugging me enough and wasting my GPU time too much that I felt a need to fix it.

Adds an attribute to track the current index and prevents logging an image if there has already been a logging attempt at the current index.

This prevents a circumstance where the image logger can trigger more than once in rapid succession, generally when multiple iterations occur during a single global step, such as:

  • When accumulate_grad_batches > 1.
  • When the validation data-loader triggers at the end of an epoch, and that global step happens to align with image logging.

Adds a variable to track the current index and prevents logging an image if there has already been a logging attempt at the current index.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant