Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the upon template engine #7

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

namebee
Copy link

@namebee namebee commented Nov 24, 2024

I've added upon to the benchmark as I have been considering it as an option for one of my projects and I could not find a good speed comparison to other engines.

@Kijewski
Copy link
Collaborator

Thank you for your PR! Your implementation looks good, but I have a small problem with the library itself.

Automatic HTML escaping is, at least for me, an essential feature, and our readme also mentions that all tested libraries do HTML escaping by default. upon does not. To me, this is too big a security risk to promote the library. Once auto-HTML-escaping becomes configurable, I'd be happy to add it to the list!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants