"object safe" is now "dyn-compatible" #199
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kijewski
commented
Oct 12, 2024
rinja/src/lib.rs
Outdated
| /// This trades reduced performance (mostly due to writing into `dyn Write`) for object safety. | ||
| /// This trades reduced performance (mostly due to writing into `dyn Write`) for dyn-compatibility. | ||
| /// | ||
| /// [`dyn`-compatible]: <https://doc.rust-lang.org/stable/reference/items/traits.html#object-safety> |
There was a problem hiding this comment.
Waiting for rust-lang/reference#1512 to land, so the link fragment can be updated.
There was a problem hiding this comment.
Implemented in rust-lang/reference#1666. The new version is not live, yet, but it will be soon enough.
Kijewski
force-pushed
the
pr-dyn-compat
branch
from
d13873c to
c25e149
Compare
The phrase was changed in <rust-lang/rust#130852>.
Kijewski
force-pushed
the
pr-dyn-compat
branch
from
c25e149 to
c02b251
Compare
| @@ -170,9 +170,11 @@ impl<T: Template + ?Sized> Template for &T { | |||
| const MIME_TYPE: &'static str = T::MIME_TYPE; | |||
| } | |||
|
|
|||
| /// Object-safe wrapper trait around [`Template`] implementers | |||
| /// [`dyn`-compatible] wrapper trait around [`Template`] implementers | |||
There was a problem hiding this comment.
Suggested change
| /// [`dyn`-compatible] wrapper trait around [`Template`] implementers | |
| /// [`dyn`-compatible] wrapper trait around [`Template`] implementors. |
In rust docs it's "implementors" so I suppose it's the correct word. ^^'
There was a problem hiding this comment.
Oops, thank you for proofreading!
(I'm like 99% sure that in English you are supposed to role a dice when to write -ter and when to write -tor. :D)
There was a problem hiding this comment.
Yup, and let's not even try to speak english, the pronunciation is even more random. 😆
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The phrase was changed in rust-lang/rust#130852.