Load templates from relative paths #1112
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Templates can now be placed directly next to the source file that they are defined in as a default. This relies on an unstable rust compiler feature, which exposes the source file to proc macros. See <rust-lang/rust#54725> for more info. This requires the nightly compiler to run, and enabling the proc_macro_span and procmacro2_semver_exempt cfg flags. To build / test: ```shell RUSTFLAGS='--cfg proc_macro_span --cfg procmacro2_semver_exempt' \ cargo +nightly build ``` Fixes: <https://github.com/djc/askama/issues/877>
joshka
force-pushed
the
jm/relative-paths
branch
from
381cb2c to
b6106c5
Compare
joshka
commented
Dec 3, 2024
Comment on lines
+32
to
+35
| ## Enables the ability to put templates in a directory relative to the source file that uses them. | ||
| ## Requires a nightly compiler and adding: | ||
| ## RUSTFLAGS='--cfg proc_macro_span --cfg procmacro2_semver_exempt' | ||
| ## to your cargo build command. |
There was a problem hiding this comment.
Consider adding the document-features crate so this info can automatically populate the lib.rs doc comment without having to duplicate it.
joshka
commented
Dec 3, 2024
| @@ -26,7 +26,22 @@ impl<'a> Config<'a> { | |||
| template_whitespace: Option<&str>, | |||
| ) -> std::result::Result<Config<'a>, CompileError> { | |||
| let root = PathBuf::from(env::var("CARGO_MANIFEST_DIR").unwrap()); | |||
| let default_dirs = vec![root.join("templates")]; | |||
| let root_path = root.join("templates"); | |||
| let default_dirs; | |||
There was a problem hiding this comment.
It's probable that the logic of which dirs end up in the list when config is taken into account might have to be a little more complex than this current logic. The crux of the problem is solved however, leaving the choice of how it should be behave remaining. I.e. if the user has a config file and it has dirs specified should we still resolve relative paths, should there be a config for this, ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Templates can now be placed directly next to the source file that they
are defined in as a default. This relies on an unstable rust compiler
feature, which exposes the source file to proc macros. See
rust-lang/rust#54725 for more info.
This requires the nightly compiler to run, and enabling the
proc_macro_span and procmacro2_semver_exempt cfg flags. To build / test:
RUSTFLAGS='--cfg proc_macro_span --cfg procmacro2_semver_exempt' \ cargo +nightly buildFixes: https://github.com/djc/askama/issues/877
TODO:
relative-pathsfor this)