Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(common): replace std unordered container with boost's #937

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

WhiredPlanck
Copy link
Contributor

Pull request

Issue tracker

Fixes will automatically close the related issue

Fixes # N/A

Feature

Describe feature of pull request

The latter has considerable performance improvement compared with the former.

Unit test

  • Done

Manual test

  • Done

Code Review

  1. Unit and manual test pass
  2. GitHub Action CI pass
  3. At least one contributor reviews and votes
  4. Can be merged clean without conflicts
  5. PR will be merged by rebase upstream base

Additional Info

src/rime/common.h Outdated Show resolved Hide resolved
The latter has considerable performance improvement compared with the former.
@WhiredPlanck WhiredPlanck changed the title perf(common): replace std unordered_map with boost's perf(common): replace std unordered container with boost's Oct 10, 2024
@ksqsf ksqsf merged commit b907d7d into rime:master Oct 11, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants