fix(build): limit default parallelism to 8 cores #932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksqsf
changed the title
ksqsf
force-pushed
the
makeflags
branch
2 times, most recently
from
210ca39
to
71794fe
Compare
On systems where nproc is not available, it will leave only -j which causes unlimited parallelism.
lotem
approved these changes
Sep 1, 2024
Coloryr
reviewed
Sep 2, 2024
There was a problem hiding this comment.
Yes. The job count is usually nproc+1 or +2 to make full use of the CPU power.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On systems where nproc is not available, it will leave only -j which causes unlimited parallelism.
Note: macos CI build already uses ninja which properly handles parallelism.
Pull request
Issue tracker
Fixes will automatically close the related issue
Fixes #856
Feature
Describe feature of pull request
Unit test
Manual test
Code Review
Additional Info