fix: query cancellation issue #6319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericpgreen2
approved these changes
Dec 20, 2024
ericpgreen2
pushed a commit
that referenced
this pull request
Dec 20, 2024
* fix: query cancellation issue * type fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this file, we're refetching the project when the application tab is refocused.
This refetch meant we were receiving a new JWT each time. The JWT is colocated in a store that also handles the host and instanceId variables, so updating one triggers a reactive update for all of them.
In our state managers, the explore spec and time range summary are dependent on the runtime store.
In Leaderboards, the primary aggregation query is dependent on an array of measures and the time range, which are derived from those queries. So, on window focus, the parameters were updating and the pending query was cancelled/re-initiated.
This is a patch fix for that issue and does not address the underlying structural flaw.