Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add accessible labels for workspace toggles #6308

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

briangregoryholmes
Copy link
Contributor

@briangregoryholmes briangregoryholmes commented Dec 19, 2024

Adds the ability to select these buttons using page.getByLabel("Toggle table visibility") and page.getByLabel("Toggle inspector visibility") when constructing Playwright tests

Copy link
Contributor

@royendo royendo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ty! LGTM

@briangregoryholmes briangregoryholmes merged commit 9b1bd5f into main Dec 20, 2024
9 checks passed
@briangregoryholmes briangregoryholmes deleted the bgh/accessible-label branch December 20, 2024 15:53
royendo added a commit that referenced this pull request Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants