fix: avoid using global runtime in loader funciton #6280
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdityaHegde
added
the
blocker
AdityaHegde
force-pushed
the
fix/runtime-init-in-loader
branch
from
7374789 to
86275ba
Compare
|
We are opting to disable preload on links to other projects in the breadcrumbs and any other places. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were setting the global runtime in project's loader function and using it in explore's loader function to fetch explore spec and other data. This would cause issue with preloading routes where loader function gets called. Hovering over other projects in breadcrumbs would update the runtime causing the dashboard list to be incorrect.
Here we are making explicit calls to
httpRuntimewith a customRuntimeobject. This should not be the final solution since changes to API is not auto generated. We should look at autogenerating thesefetchwrappers for every API.