-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: file conflict resolution #6272
Conversation
briangregoryholmes
commented
Dec 12, 2024
•
edited
Loading
edited
- Updates conflict detection logic to be less intrusive
- Updates alert copy
- Adds diff/merge view
- Adds saving/error indicators to sidebar and save button
@briangregoryholmes : Is this ready for review ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, feels good!
UXQA:
- With autosave disabled, I add text (e.g. "abc"), then delete that same text, then attempt to save the file (the "unsaved changes" indicator was showing), it fails to save. (Jam)
- After I accept remote changes, I see the red exclamation point.
@mindspank could we call you the Product Owner of the code editor, and can you give this a look too?
All fixed. I also extended the autosave debounce to 650ms, which feels better to me. |
The "Accept current" button is unresponsive for me: Jam |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving so you can merge at your discretion