Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: comparison time ranges resetting when switching time ranges #6270

Merged
merged 3 commits into from
Dec 13, 2024
Merged

fix: comparison time ranges resetting when switching time ranges #6270

merged 3 commits into from
Dec 13, 2024

Conversation

AdityaHegde
Copy link
Collaborator

  • When switching time ranges, comparison time range would reset.
  • Just after switching on compare dimension toggling comparison time range would not apply.
  • If comparison is disabled comparison based criteria was still allowed in alerts.

@AdityaHegde AdityaHegde added the blocker A release blocker issue that should be resolved before a new release label Dec 12, 2024
djbarnwal
djbarnwal reviewed Dec 13, 2024
View reviewed changes
Copy link
Member

@djbarnwal djbarnwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the change to the Select component intentional in this PR? I see the change in the component but no change in it's usage

web-common/src/features/alerts/criteria-tab/getTypeOptions.ts Outdated Show resolved Hide resolved
@AdityaHegde
Copy link
Collaborator Author

AdityaHegde commented Dec 13, 2024 •
edited
Loading

Looks like a refactor to Select component removed the capability needed in alerts. But the alerts form was not updated. We still need the readonly option with tooltip so adding it back.

@djbarnwal djbarnwal merged commit d4d4ab8 into main Dec 13, 2024
7 checks passed
@djbarnwal djbarnwal deleted the fix/comparison-time-ranges branch December 13, 2024 10:12
AdityaHegde added a commit that referenced this pull request Dec 16, 2024
@AdityaHegde
fix: comparison time ranges resetting when switching time ranges (#6270)
2705c48 
* Fix comparison being disabled while switching time ranges

* Fix disabled comparison not disabling comparison options in alert criteria

* Remove console.log
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djbarnwal djbarnwal djbarnwal approved these changes

Assignees
No one assigned
Labels
blocker A release blocker issue that should be resolved before a new release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AdityaHegde @djbarnwal