Don't show the "Source imported successfully" modal when unpacking example projects #6260
Conversation
| @@ -30,6 +30,7 @@ type FeatureFlagKey = keyof Omit<FeatureFlags, "set">; | |||
| class FeatureFlags { | |||
| adminServer = new FeatureFlag("rill", false); | |||
| readOnly = new FeatureFlag("rill", false); | |||
| sourceImportedModal = new FeatureFlag("rill", true); | |||
There was a problem hiding this comment.
We should not use FeatureFlags for this. Lets have a separate set of values for such use cases.
|
I agree with Aditya, but also think we should just remove this modal entirely for the time being. Forcing the user to choose one of these options isn't a good user experience even when it works properly. This should be part of a more robust toast notification system or we should develop a way of pointing out the CTA button via a small animation when certain conditions are met. If you do go forward with this, the reason it shouldn't be shown is because there is already a downstream dashboard, so I would look into basing the hide/show rules around that, which may not require the use of a store. |
I agree this modal feels quite ham-fisted and that we could give the user a much more elegant nudge. For the time being, for the sake of keeping some CTA (which I believe Mike feels strongly about), I'll patch this as is.
Done! |
ericpgreen2
deleted the
no-source-import-modal-for-unpacked-example-projects
branch
…ample projects (#6260) * Don't show the "Source imported successfully" modal when unpacking example projects * Review
Reported in the bug bash