Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: leaderboard column percent of total width #6243

Merged
merged 2 commits into from
Dec 11, 2024
Merged

fix: leaderboard column percent of total width #6243

merged 2 commits into from
Dec 11, 2024

Conversation

briangregoryholmes
Copy link
Contributor

@briangregoryholmes briangregoryholmes commented Dec 9, 2024 •
edited
Loading

  • Fixes an issue where the leaderboard percent of total bar was unnecessarily factoring in the width of the checkmark gutter
  • Updates the column width implementation to be based on the rendered size of the element rather than an estimate based on the number of characters
  • Other cleanup

Closes: #976

@briangregoryholmes briangregoryholmes self-assigned this Dec 9, 2024
@djbarnwal djbarnwal merged commit 349c759 into main Dec 11, 2024
7 checks passed
@djbarnwal djbarnwal deleted the bgh/leaderboard-column-tweaks branch December 11, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djbarnwal djbarnwal djbarnwal approved these changes

Assignees

@briangregoryholmes briangregoryholmes

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@briangregoryholmes @djbarnwal