Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: decode known yaml fields, display errors in generic file workspace #6240

Merged
merged 7 commits into from
Dec 12, 2024

Conversation

briangregoryholmes
Copy link
Contributor

@briangregoryholmes briangregoryholmes commented Dec 9, 2024

@briangregoryholmes briangregoryholmes self-assigned this Dec 9, 2024
@briangregoryholmes briangregoryholmes changed the title fix: display parse errors on generic file workspaces fix: display parse errors in generic file workspace Dec 9, 2024
@briangregoryholmes briangregoryholmes changed the title fix: display parse errors in generic file workspace fix: decode known yaml fields, display errors in generic file workspace Dec 9, 2024
@briangregoryholmes briangregoryholmes linked an issue Dec 9, 2024 that may be closed by this pull request
Copy link
Contributor

@begelundmuller begelundmuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@briangregoryholmes briangregoryholmes merged commit 3e30dad into main Dec 12, 2024
9 checks passed
@briangregoryholmes briangregoryholmes deleted the bgh/display-workspace-errors branch December 12, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show rill.yaml parser errors in the UI
2 participants