fix: URL params UXQA items #6225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericpgreen2
approved these changes
Dec 6, 2024
web-common/src/features/dashboards/stores/dashboard-store-defaults.ts
Outdated
Show resolved
Hide resolved
Comment on lines
240
to
245
| url.searchParams.forEach((value, key) => { | ||
| // ignore `view` param since it is already part of partialExploreState | ||
| // in case `view` was same as default adding it here would mess up the order. | ||
| if (key === ExploreStateURLParams.WebView) return; | ||
| newUrl.searchParams.set(key, value); | ||
| }); |
There was a problem hiding this comment.
It looks like this logic should go in the convertExploreStateToURLSearchParams() function. Whenever the view is the default view, it shouldn't be stringified into query params (which it looks like the shouldSetParam() function is for).
There was a problem hiding this comment.
Good point. But convertExploreStateToURLSearchParams is not the one adding the params here. It is getUrlForWebView that always set the view, it should not set it if it is default.
There was a problem hiding this comment.
I think it's fine for it to set explicit parameters, then the load function can remove (via redirect) any parameters that are defaults
AdityaHegde
added a commit
that referenced
this pull request
Dec 9, 2024
* URL params UXQA items * Fix lint * PR comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tzparam. Note that the default of UTC / localIANA is used still.viewin the correct order when switching using the tabs.grainshould not appear in pivot.