DuckDB with backup on GCS #6006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
begelundmuller
requested changes
Nov 8, 2024
…-duckdb-replicator
begelundmuller
requested changes
Dec 10, 2024
begelundmuller
approved these changes
Dec 13, 2024
| bootQueries = append(bootQueries, | ||
| "SET preserve_insertion_order TO false", | ||
| fmt.Sprintf("SET temp_directory = %s", safeSQLString(tempDir)), | ||
| fmt.Sprintf("SET secret_directory = %s", safeSQLString(filepath.Join(dataDir, ".duckdb", "secrets"))), |
There was a problem hiding this comment.
Will this interfere with external table storage or will it just be ignored?
There was a problem hiding this comment.
Good point. These queries are executed for every db file so setting secret_directory is what is expected.
But there could be issues if all database share same tmp directory. May be for new removing temp_directory seems to be a safe option.
More important was to set unique secret_directory for each instance's database.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes https://github.com/rilldata/rill-private-issues/issues/692
Some of the previous logic removed from existing driver logic.
.tmpand.walfiles if they are bigger than a certain size. Even on main it no longer works because thetmpandwalactually gets built in the attached DBs and notmain.enumconversion feature. Not being used anywhere and not documented as well. Can be added in therduckdbif use case comes again.txsupport in duckdb driver. We no longer need to block read queries while attaching detaching.