Refactor: Preview Table #4529
Merged
Refactor: Preview Table #4529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericpgreen2
approved these changes
Apr 16, 2024
djbarnwal
requested changes
Apr 17, 2024
There was a problem hiding this comment.
Thanks for the PR Brian. Couple of regressions (I am on firefox) -
- The table for model/sources is not styled right
- The column size is not adaptive. I would expect the columns with smaller values and header (in length) to have a thinner column. (Not a blocker but good to have if it doesn't add performance issues)
|
@djbarnwal Got the Firefox one. Column sizes are set variably, but I was applying too much buffer, so that's been addressed as well. |
djbarnwal
approved these changes
Apr 18, 2024
web-common/src/components/virtualized-table/VirtualTable.svelte
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a performance-focused, zero dependency
VirtualTablecomponent with row and column virtualization. In this PR, it is used to replace all instances ofPreviewTableacross the application, but the component has been designed in such a way that it should also work as a replacement forDimensionTableandTDDTablein the future (with expected modifications). That said, reviews of this PR should consider it only as a replacement forPreviewTable. It features an improved handling of Tooltips, but one that is separate from the proposal for a global overhaul of that system.You should see improvements in page load times, table render times, scroll performance, column resize frame rate, workspace responsiveness and heap snapshot size when viewing the table.